Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm] Separate out mutative methods for joinPool, exitPool and swap functions #1142

Closed
Tracked by #1450
mattverse opened this issue Mar 24, 2022 · 0 comments · Fixed by #1147
Closed
Tracked by #1450

[x/gamm] Separate out mutative methods for joinPool, exitPool and swap functions #1142

mattverse opened this issue Mar 24, 2022 · 0 comments · Fixed by #1147
Assignees
@mattverse

Comments

@mattverse
Copy link
Member

Currently we have non mutative operations, CalcInAmtGivenOut, CalcOutAmtGivenIn, and mutative operations: ApplySwap, JoinPool, ExitPool.

In the extent of allowing more code duplications, we want to have more options for the methods we want to have in our poolI interface, something that looks like such:

* CalcInAmtGivenOut
* CalcOutAmtGivenIn
* SwapInAmtGivenOut
* SwapOutAmtGivenIn

* CalcJoinPoolShares
* CalcExitPoolShares
* JoinPool
* ExitPool
@mattverse mattverse mentioned this issue Mar 24, 2022
Closed
6 tasks
@mattverse mattverse self-assigned this Mar 24, 2022
@mattverse mattverse mentioned this issue Mar 25, 2022
Merged
4 tasks
@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development Mar 30, 2022
Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Apr 5, 2022
@p0mvn p0mvn changed the title Separate out mutative methods for joinPool, exitPool and swap functions [x/gamm] Separate out mutative methods for joinPool, exitPool and swap functions May 9, 2022
@p0mvn p0mvn mentioned this issue May 9, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mutative, non mutative method for PoolI osmosis-labs/osmosis
1 participant
@mattverse