Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go 1.18 typecheck lints in old release branches (v5.x, v4.x, v3.x) #1296

Open
1 task
ValarDragon opened this issue Apr 19, 2022 · 2 comments
Open
1 task

Fix go 1.18 typecheck lints in old release branches (v5.x, v4.x, v3.x) #1296

ValarDragon opened this issue Apr 19, 2022 · 2 comments
Labels
Good first issue

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Apr 19, 2022 •
edited
Loading

These old branches have typecheck lint errors, now that relevant tooling is on go1.18. We need to fix these for lint to pass on PRs to those branches.

Acceptance Criteria

  • Linting in CI passes on v3.x, v4.x, v5.x and v6.x
@ValarDragon ValarDragon mentioned this issue Apr 20, 2022
Merged
4 tasks
@akaladarshi
Copy link

Hey @ValarDragon is this task still open? and If it is can i work on it?

@czarcas7ic
Copy link
Member

Hey @ValarDragon is this task still open? and If it is can i work on it?

You are good to work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
Osmosis Chain Development
Status: Todo 🕒
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @akaladarshi @czarcas7ic