Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/lockup: Enable users to elongate the lockup period for locked tokens #164

Closed
ValarDragon opened this issue May 7, 2021 · 2 comments · Fixed by #1253
Closed

x/lockup: Enable users to elongate the lockup period for locked tokens #164

ValarDragon opened this issue May 7, 2021 · 2 comments · Fixed by #1253

Comments

@ValarDragon
Copy link
Member

ValarDragon commented May 7, 2021

Suppose a user has locked up 10 tokens for 2 days. We should allow them to increase the lockup period to 1 week, without having to unlock and relock. This will probably require a new message type in x/lockup to do this, as we need the user to specify which initial lockup time duration they want to increase.

(E.g. if they have 10 tokens locked for 2 days, 20 tokens locked for 4 days, and want to move the 20 tokens to a lockup of 1 week)

Also this should only support increasing the lockup duration, not decreasing it

@ValarDragon
Copy link
Member Author

Prelaunch we should just ensure that this will be easy to upgrade in the future / double check how we handle state / implicit assumptions around this.

@mconcat
Copy link
Collaborator

mconcat commented Jun 7, 2021

Adding MsgEditLockup would work and we can check that lockup duration change is positive in ValidateBasic. This would be extensible in the future for other modifications too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants