Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all messages work with Authz #2099

Closed
3 tasks
ValarDragon opened this issue Jul 17, 2022 · 3 comments · Fixed by #2206
Closed
3 tasks

Ensure all messages work with Authz #2099

ValarDragon opened this issue Jul 17, 2022 · 3 comments · Fixed by #2206
Assignees
Milestone

Comments

@ValarDragon
Copy link
Member

Background

Apply API breaking changes from cosmos/cosmos-sdk#11224 into the Osmosis code. This is already in osmosis main from: osmosis-labs/cosmos-sdk#224 , so we just need to apply it to our code and check that it works / nothing broke.

Suggested Design

Apply API changes from aforementioned PR
Check that existing txs still work signed via CLI, ledger, authz CLI and authz ledger. (Can we get a golang test for this? A golang test would also help with mutation testing's highlight of a testing gap here0

Acceptance Criteria

  • API changes done
  • Golang test Txs signed in ledger format, normal format, and Authz still work. (Pass in an SDK.Msg with signer field filled)
  • Manual test to sanity check
@vuong177
Copy link
Contributor

vuong177 commented Jul 18, 2022

Hi @ValarDragon, can I try doing this issue ?

@p0mvn p0mvn added this to the V11 milestone Jul 19, 2022
@p0mvn
Copy link
Member

p0mvn commented Jul 21, 2022

Hi @vuong177

You can take this if you'd like. However, I would like to warn you that there is a lot of uncertainty with this. As a result, guidance and help might be limited.

The goal is to have this before the end of the current sprint (end of next week).

So if you'd like to work on something open-ended while having these constraints in mind, feel free to take this.

Please let me know if you are planning on working on this

@vuong177
Copy link
Contributor

@p0mvn yes. I'd love to take this work.

@vuong177 vuong177 mentioned this issue Jul 24, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants