lint: investigate static-analysis tool to make sure all iterators are closed

[p0mvn]

Background

We need a static analysis tool to detect iterators that were not closed.

Example problem:

osmosis/x/superfluid/keeper/intermediary_account.go

Line 134 in a1dc694

iterator := prefixStore.Iterator(nil, nil)

Suggested Approach

• Look at linters here and see if any of these have the required tool available: https://golangci-lint.run/usage/linters/
• If none available, determine what it takes to implement our own

Acceptance Criteria

• find a concrete way to integrate a check for ensuring that all iterators are closed into our repository
• write a follow-up issue with concrete steps needed to be done

[ValarDragon]

I feel like this has to be something handled within gosec

[faddat]

So, I can think of 2-3 ways to do it, but in our internal chat, I started here:

https://github.com/crypto-com/cosmos-sdk-codeql

there's also:

https://github.com/informalsystems/gosec

but in general, the crypto.com tooling has replaced the informalsysstems/gosec repo in our code practice.