Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addToExistingLock in E2E test framework #2557

Closed
czarcas7ic opened this issue Aug 31, 2022 · 0 comments · Fixed by #2571
Closed

Add addToExistingLock in E2E test framework #2557

czarcas7ic opened this issue Aug 31, 2022 · 0 comments · Fixed by #2571
Assignees
Milestone

Comments

@czarcas7ic
Copy link
Member

czarcas7ic commented Aug 31, 2022

Background

We recently refactored AddToExistingLock in this PR #1979

As discussed in a call, we should have test coverage on this, and the e2e test suite seems like a good place for this

Suggested Design

  • After a lock is created in e2e, add to that existing lock pre upgrade
    • If upgrade is not skipped, after the upgrade, we should attempt to add to the lock that existed pre upgrade as well as a lock that was created post upgrade
    • If upgrade is skipped, just attempt to add to an existing lock that was created
  • Ensure the above is done for both superfluid and non superfluid locks

Acceptance Criteria

  • design implemented with all tests passing
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Aug 31, 2022
@czarcas7ic czarcas7ic self-assigned this Sep 1, 2022
@czarcas7ic czarcas7ic added this to the V12 Blockers milestone Sep 1, 2022
@czarcas7ic czarcas7ic moved this from Needs Review 🔍 to Needs PR Review in Osmosis Chain Development Sep 2, 2022
Repository owner moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant