You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before introducing ChopPrecision(Mut) functions, we had to use various hacks of get rid of precision of a BigDec (for example, to scale it to Dec's precision, which can be seen in referenced above comment). With introduction of mentioned helpers, there is no more need to use hacks
Checked
Inspected filepaths are:
filepath -> link to PR (example)
Acceptance criteria
For a PR to be accepted it does NOT need to introduce changes to absolutely every place in codebase where a hack is used. A PR is eligible if it introduces at least some hacks refactored (though in this case, files that were checked by PR's author should be included in this issue: either by leaving a comment or editing a Checked section of this issue)
The text was updated successfully, but these errors were encountered:
p0mvn
changed the title
Seems like there are couple of other places in code base where we can use this new method, do we have future plans to change to this method?
Review codebase and use ChopPrecisionMut helper where applicable
Sep 20, 2023
Originally posted by @mattverse in #6261 (comment)
Background
Before introducing
ChopPrecision(Mut)
functions, we had to use various hacks of get rid of precision of aBigDec
(for example, to scale it toDec
's precision, which can be seen in referenced above comment). With introduction of mentioned helpers, there is no more need to use hacksChecked
Inspected filepaths are:
Acceptance criteria
For a PR to be accepted it does NOT need to introduce changes to absolutely every place in codebase where a hack is used. A PR is eligible if it introduces at least some hacks refactored (though in this case, files that were checked by PR's author should be included in this issue: either by leaving a comment or editing a
Checked
section of this issue)The text was updated successfully, but these errors were encountered: