Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review codebase and use ChopPrecisionMut helper where applicable #6467

Open
p0mvn opened this issue Sep 20, 2023 · 1 comment
Open

Review codebase and use ChopPrecisionMut helper where applicable #6467

p0mvn opened this issue Sep 20, 2023 · 1 comment

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 20, 2023

          Seems like there are couple of other places in code base where we can use this new method, do we have future plans to change to this method?

Originally posted by @mattverse in #6261 (comment)

Background

Before introducing ChopPrecision(Mut) functions, we had to use various hacks of get rid of precision of a BigDec (for example, to scale it to Dec's precision, which can be seen in referenced above comment). With introduction of mentioned helpers, there is no more need to use hacks

Checked

Inspected filepaths are:

  • filepath -> link to PR (example)

Acceptance criteria

For a PR to be accepted it does NOT need to introduce changes to absolutely every place in codebase where a hack is used. A PR is eligible if it introduces at least some hacks refactored (though in this case, files that were checked by PR's author should be included in this issue: either by leaving a comment or editing a Checked section of this issue)

@p0mvn p0mvn changed the title Seems like there are couple of other places in code base where we can use this new method, do we have future plans to change to this method? Review codebase and use ChopPrecisionMut helper where applicable Sep 20, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 20, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Sep 20, 2023

@pysel please edit issue to share context and acceptance criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

1 participant