Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatblocks -> something checked into repo #588

Closed
MattHJensen opened this issue Jul 20, 2017 · 2 comments
Closed

flatblocks -> something checked into repo #588

MattHJensen opened this issue Jul 20, 2017 · 2 comments
Milestone

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented Jul 20, 2017

After I updated the ospc.org/taxbrain user tips in response to #585, @martinholmer asked:

@MattHJensen, So how did this new documentation get added to TaxBrain?
I can't see any pull request that made the change.

What happened is that I updated a django-flatbock via the Django admin.

@martinholmer further noted that:

If we want TaxBrain development to be more transparent, changes like this need to be more visible.

I agree entirely. Our current reliance on flatblocks has a few detrimental effects

  • undermines the open approach of the TaxBrain project.
  • means that we are not tracking changes to text and not reaping the benefits of version control.
  • means that our test app often looks different than our production app.

One simple solution that comes to mind would be to edit the html directly in the webapp-public source code rather than via flatbocks. That would be fine with me, although other suggestions are very welcome.

@brittainhard @GoFroggyRun @hdoupe @martinholmer

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 22, 2017

@MattHJensen said

One simple solution that comes to mind would be to edit the html directly in the webapp-public source code rather than via flatbocks.

This makes sense to me. I don't know what the technical obstacles are here, but the current system discourages contributors from making what should be trivial fixes (see #649, #662).

@martinholmer

@hdoupe
Copy link
Collaborator

hdoupe commented Oct 26, 2017

Closed via #711

@hdoupe hdoupe closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants