-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend for bubble plot #764
Comments
@jdebacker said:
OK, thanks for the explanation. But is the "amount of assets" proportional to the diameter of the circle or the area of the circle? The size of a circle can have two different meanings. |
@hayleefay @andersonfrailey are you interested in tackling this issue? |
I can take a crack at it |
@andersonfrailey Awesome, thanks. See #642 for the original work. Let me know if there's anything else I can do to help you get started. |
@jdebacker, what should each size bubble be labeled? |
@andersonfrailey I don't think the sizes are predetermined. Rather, there is a different bubble size for each of 15 quantiles of the distribution of assets. See here. I'd recommend labeling only the smallest and largest bubbles as done here so as not to make the legend too busy. @hayleefay might have other suggestions are the creator of this particular plot. |
@andersonfrailey Looks pretty good. I think some text to say that those are amount of assets on the label could be helpful. Also, I might try to locate it on top (or bottom) of the graph since horizontal space is more limited than vertical space when displayed on the screen. |
|
@andersonfrailey Looks good to me! Nicely done. |
@andersonfrailey @hdoupe @jdebacker I'm sorry I have been MIA for this issue. That looks great, Anderson. The plot was modeled after the one Jason linked so that is definitely the correct legend. |
@andersonfrailey, @hayleefay, @jdebacker Thanks for your work on this issue. |
Closed via #809 |
@martinholmer asks:
The bubble sizes are based on the amount of assets of that type (or in that industry). We should probably add a legend for this to the plot so it's clear. An example can be found from this widget in the OSPC gallery.
cc @hayleefay
The text was updated successfully, but these errors were encountered: