Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend for bubble plot #764

Closed
jdebacker opened this issue Dec 4, 2017 · 13 comments
Closed

Legend for bubble plot #764

jdebacker opened this issue Dec 4, 2017 · 13 comments
Labels

Comments

@jdebacker
Copy link
Contributor

@martinholmer asks:

When first looking at the "bubble plot" on the results page of the CCC, I didn't see where the meaning of the size of the bubble was explained. Did I miss the explanation? What does the size of the bubble mean?

The bubble sizes are based on the amount of assets of that type (or in that industry). We should probably add a legend for this to the plot so it's clear. An example can be found from this widget in the OSPC gallery.

cc @hayleefay

@jdebacker jdebacker added the CCC label Dec 4, 2017
@martinholmer
Copy link
Contributor

@jdebacker said:

When first looking at the "bubble plot" on the results page of the CCC, I didn't see where the meaning of the size of the bubble was explained. Did I miss the explanation? What does the size of the bubble mean?

The bubble sizes are based on the amount of assets of that type (or in that industry). We should probably add a legend for this to the plot so it's clear. An example can be found from this widget in the OSPC gallery.

OK, thanks for the explanation. But is the "amount of assets" proportional to the diameter of the circle or the area of the circle? The size of a circle can have two different meanings.

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 17, 2018

@hayleefay @andersonfrailey are you interested in tackling this issue?

@andersonfrailey
Copy link
Contributor

I can take a crack at it

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 18, 2018

@andersonfrailey Awesome, thanks. See #642 for the original work. Let me know if there's anything else I can do to help you get started.

@andersonfrailey
Copy link
Contributor

@jdebacker, what should each size bubble be labeled?

@jdebacker
Copy link
Contributor Author

jdebacker commented Jan 18, 2018

@andersonfrailey I don't think the sizes are predetermined. Rather, there is a different bubble size for each of 15 quantiles of the distribution of assets. See here.

I'd recommend labeling only the smallest and largest bubbles as done here so as not to make the legend too busy.

@hayleefay might have other suggestions are the creator of this particular plot.

@andersonfrailey
Copy link
Contributor

How's this look:
screen shot 2018-01-18 at 3 31 57 pm

@jdebacker
Copy link
Contributor Author

@andersonfrailey Looks pretty good. I think some text to say that those are amount of assets on the label could be helpful.

Also, I might try to locate it on top (or bottom) of the graph since horizontal space is more limited than vertical space when displayed on the screen.

@andersonfrailey
Copy link
Contributor

screen shot 2018-01-18 at 4 53 31 pm
@jdebacker how's this?

@jdebacker
Copy link
Contributor Author

@andersonfrailey Looks good to me! Nicely done.

@hayleefay
Copy link
Contributor

@andersonfrailey @hdoupe @jdebacker I'm sorry I have been MIA for this issue. That looks great, Anderson. The plot was modeled after the one Jason linked so that is definitely the correct legend.

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 19, 2018

@andersonfrailey, @hayleefay, @jdebacker Thanks for your work on this issue.

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 19, 2018

Closed via #809

@hdoupe hdoupe closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants