Add CONFIG_BOOT_RECOVERY_SERIAL to qemu board configs to interact with host through serial #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h host through serial
|
@JonathonHall-Purism please review! |
|
Works for me, did a quick test of qemu-fbwhiptail-tpm1-hotp under Debian Qemu/KVM. Looks great 🚢 |
|
We can improve on that on #1245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result, you will get expected pause_recovery (etc/functions) output "Hit enter to proceed to recovery shell:" prompt on ttyS0 (stdio: where qemu is launched) while whiptail is shown only once on host (qemu/kvm).
This is important in case of TPM, since entering recovery shell will invalidate measurements and prevent TPM disk encryption key to be unsealed if going to recovery shell.
By removing the CONFIG_BOOT_RECOVERY_SERIAL board configuration export, only dmesg is redirected to ttyS0 (helpful to debug)