x230-maximized boards: build against coreboot 4.13 #949

tlaurion · 2021-01-02T17:13:24Z

Smaller step to #944 since t430 hypothesized to not boot. x230 only here.

bwachter · 2021-01-04T13:40:57Z

After spending way too long on this because parallel builds are broken I didn't get past the kernel compilation step:

$ make BOARD=x230-maximized build=/tmp/heads
[...]
make[2]: Leaving directory '/tmp/heads/coreboot-4.13'
2021-01-04 13:35:08+00:00 CONFIG coreboot
/tmp/heads/make-4.2.1/make \
        -C "/tmp/heads/linux-4.14.62" \
        INSTALL_HDR_PATH="/home/bwachter/git/misc/heads/install" \
        O="linux-4.14.62/linux-x230" \
        KCONFIG_CONFIG="/home/bwachter/git/misc/heads/config/linux-x230.config" \
        headers_install
make[2]: Entering directory '/tmp/heads/linux-4.14.62'
make[3]: Entering directory '/tmp/heads/linux-4.14.62/linux-4.14.62/linux-x230'
  CHK     include/generated/uapi/linux/version.h
make[4]: *** No targets specified and no makefile found.  Stop.
make[3]: *** [/tmp/heads/linux-4.14.62/Makefile:463: scripts_basic] Error 2
make[3]: Leaving directory '/tmp/heads/linux-4.14.62/linux-4.14.62/linux-x230'
make[2]: *** [Makefile:146: sub-make] Error 2
make[2]: Leaving directory '/tmp/heads/linux-4.14.62'
make[1]: *** [modules/linux:47: /home/bwachter/git/misc/heads/install/include/linux/limits.h] Error 2
make[1]: Leaving directory '/home/bwachter/git/misc/heads'
make: *** [Makefile:648: all] Error 2

tlaurion · 2021-01-04T21:18:10Z

@bwachter can you elaborate? CI builds are building with
make BOARD=x230-maximized CPUS=4 V=1 without error as of right now, where #935 seems to be a thing, where I was't able to reproduce.

tlaurion · 2021-01-04T21:21:56Z

@bwachter CircleCI building each commit is on debian-10. What is your host OS?
(Note that #950 should be merged, which stops CIs builds to randomly fails because of some gnu mirrors having bad https certs right now)

tlaurion · 2021-01-04T21:23:04Z

@bwachter never specified build= before either.

tlaurion · 2021-01-04T21:26:13Z

Rebasing on top of #950 for CI build (click green mark on next commit to go see live build and download produced artifacts). Lost too many days waiting for GNU to ban some non-compliant mirrors.

tlaurion · 2021-01-04T23:11:07Z

@bwachter this PR built here over debian-10
Build recipe:
https://github.com/osresearch/heads/blob/master/.circleci/config.yml#L5
https://github.com/osresearch/heads/blob/master/.circleci/config.yml#L11
https://github.com/osresearch/heads/blob/master/.circleci/config.yml#L425

Build: https://app.circleci.com/pipelines/github/tlaurion/heads/684/workflows/5aa3ab80-b17e-4ef1-a979-1f7e140305da/jobs/755/steps
x230-maximized build log:https://app.circleci.com/pipelines/github/tlaurion/heads/684/workflows/5aa3ab80-b17e-4ef1-a979-1f7e140305da/jobs/755/parallel-runs/0/steps/0-198
Roms for commit c475958 as shown in name of rom:
https://755-103208611-gh.circle-artifacts.com/0/build/x230-maximized/heads-x230-maximized-v0.2.0-999-gc475958-bottom.rom
https://755-103208611-gh.circle-artifacts.com/0/build/x230-maximized/heads-x230-maximized-v0.2.0-999-gc475958-top.rom
https://755-103208611-gh.circle-artifacts.com/0/build/x230-maximized/heads-x230-maximized-v0.2.0-999-gc475958.rom

bwachter · 2021-01-05T07:50:35Z

I was trying to set MAKE_JOBS, as CPUS should get set in the Makefile, but I assume it's also not being propagated - when invoking make with CPUS set it does seem to work. That should be fixed (or at least documented), it's rather unexpected that -j doesn't work, no sensible amount of parallel tasks started automatically, and nothing mentioned in build instructions.

Still running into the same error building the Linux kernel, though. Full build log for make BOARD=x230-maximized CPUS=64 build=/tmp/heads on suse tumbleweed attached.

heads-build.log

tlaurion · 2021-01-05T15:31:44Z

@bwachter i'm sorry, I do not use tumbleweed, which is a rolling release and you will probably hit problems no one else met.
What I see from the log you posted is that the Heads Makefile stops after installing linux kernel headers, while BOARD seems not to be passed.

From the OP
make[3]: *** [/tmp/heads/linux-4.14.62/Makefile:463: scripts_basic] Error 2

Which is

scripts_basic:
        $(Q)$(MAKE) $(build)=scripts/basic
        $(Q)rm -f .tmp_quiet_recordmcount

To me, it seems that you passing build=/tmp is confusing the build environment. Could you retry without it? Or clone Heads under /tmp completely, so that you build in RAM if that is what you intend to do? Or use debian-10 docker image as in CircleCI to build Heads? Can you confirm that you have the host tools equivalents as in working CircleCI recipe for tumbleweed? (Where i'm pretty sure build toolset is more recent and will result in incompatibilities other then make and gawk which are compiled for host as of right now because of fedora and debian host tools build differences.... This is why we try to get away of having to troubleshoot all host OSes and have a docker image based on guix, or coreboot-sdk docker image, to not run over build problems in the goal of having reproducibility without bumping our heads constantly at each OS release with problems like this, where tumbleweed will definitely create problems for reproducibility, if not basic building issues, without trying to compile in rom and mess around env variables further more).

cd /tmp/heads
git clone https://github.com/osresearch/heads
cd heads
make BOARD=x230-maximized CPUS=64

report back

bwachter · 2021-01-05T18:00:42Z

On a leap 15.1 I have it failing late at the blobs (which is expected, as I didn't put anything there yet). Difference is make 4.2.1 vs make 4.3. I pretty much never run into toolchain issues on tumbleweed, and if I do it's generally rather obvious issues with the compiler or libraries. I'd recommend adding at least occasional builds on other distributions to CI and fix up the build system to behave better - that kind of very specific toolchain dependency tends to become a big burden and ties projects to outdated distributions for building eventually.

tlaurion · 2021-01-05T19:51:43Z

Needs #954 related changes

tlaurion · 2021-01-17T17:21:51Z

@bwachter I can't build in memory like you do with build=/tmp/heads

Please retry and report by doing:
make BOARD=x230-maximized CPUS=64 V=1 and post back results.

Note the successful CI build recipe:
1- build requirements
2- Blobs placed in searched blobs dirs prior of coreboot module being built
3- make call to build with 4 CPUS having debugging trace.

From the log you pasted, my eyes see no error to work on. My best hypothesis is that building in memory doesn't seem to be a passed argument, where I can't replicate easily (CIs won't accept to take that much memory).
Your build:

Sees mismatch in gawk version, compiles locally.
Sees mismatch in make, compiles locally.
Then fails at kernel install step, which is one of the first step on global makefile.

tlaurion · 2021-02-09T22:11:18Z

Considering the comments here are linked to buildsystem errors that can be mitigated per instructions, and not specific to this x230 board being bumped to coreboot 4.13, unless opposition, I will merge this PR in the following days.

tlaurion · 2021-02-09T22:15:40Z

make BOARD=x230-maximized CPUS=64 build=/tmp/heads

@bwachter : this issue should be filed into another issue called : "Cannot build in memory" and/or "Cannot build in Tumbleweed".

Successfull builds are happening https://circleci.com/gh/osresearch/heads at each merged commit on top of debian-10 docker image following CircleCI file provided in tree.

tlaurion · 2021-06-27T17:00:06Z

@MrChromebox:
https://app.circleci.com/pipelines/github/tlaurion/heads/733/workflows/a983f0a3-023f-4879-851f-027e775a6bf8/jobs/1092/artifacts build of Heads based on coreboot 4.13 boots QubesOS 4.0.4 iso and installed OS.

Rom tested:
full rom flashed: https://1092-103208611-gh.circle-artifacts.com/0/build/x230-hotp-maximized/heads-x230-hotp-maximized-v0.2.0-1040-gaf87971.rom

Bottom:
https://1092-103208611-gh.circle-artifacts.com/0/build/x230-hotp-maximized/heads-x230-hotp-maximized-v0.2.0-1040-gaf87971-bottom.rom
Top:
https://1092-103208611-gh.circle-artifacts.com/0/build/x230-hotp-maximized/heads-x230-hotp-maximized-v0.2.0-1040-gaf87971-top.rom

MrChromebox · 2021-06-28T22:59:26Z

@tlaurion thx for testing. Will have to try and figure out why Qubes 4.0.4 hangs with coreboot 4.11+ on Librem 13/15s then (no issue on Mini v1/v2/L14)

tlaurion · 2021-08-09T13:50:51Z

Superseded by #1015

tlaurion force-pushed the x230_coreboot-4_13 branch from 2b9946d to c475958 Compare January 4, 2021 21:26

tlaurion changed the title ~~x230-maximized boards: build against coreboot 4.13~~ (BRICKS T430) x230-maximized boards: build against coreboot 4.13 Jan 6, 2021

tlaurion changed the title ~~(BRICKS T430) x230-maximized boards: build against coreboot 4.13~~ x230-maximized boards: build against coreboot 4.13 Jan 6, 2021

tlaurion mentioned this pull request Jan 7, 2021

(BRICKS T430 because OPTION_TABLE) WiP: build xx30 boards against coreboot 4.13 #944

Closed

tlaurion force-pushed the x230_coreboot-4_13 branch from c475958 to ea18228 Compare January 29, 2021 20:21

tlaurion mentioned this pull request Jan 31, 2021

x230 FHD mod not supported #614

Closed

tlaurion mentioned this pull request Feb 9, 2021

Add x230-maximized-fhd_edp and x230-hotp-maximized-fhd_edp boards #967

Merged

3 tasks

x230-maximized boards: build against coreboot 4.13

af87971

tlaurion force-pushed the x230_coreboot-4_13 branch from ea18228 to af87971 Compare June 26, 2021 18:07

This was referenced Jul 23, 2021

t420-maximized boards: build against coreboot 4.13 #998

Closed

migrate all commmunity supported boards to coreboot 4.13 (Except KGPE-D16 which stays to coreboot 4.11) #1015

Merged

tlaurion closed this Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x230-maximized boards: build against coreboot 4.13 #949

x230-maximized boards: build against coreboot 4.13 #949

tlaurion commented Jan 2, 2021 •

edited

Loading

bwachter commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021 •

edited

Loading

bwachter commented Jan 5, 2021

tlaurion commented Jan 5, 2021 •

edited

Loading

bwachter commented Jan 5, 2021

tlaurion commented Jan 5, 2021

tlaurion commented Jan 17, 2021 •

edited

Loading

tlaurion commented Feb 9, 2021

tlaurion commented Feb 9, 2021

tlaurion commented Jun 27, 2021

MrChromebox commented Jun 28, 2021

tlaurion commented Aug 9, 2021

x230-maximized boards: build against coreboot 4.13 #949

x230-maximized boards: build against coreboot 4.13 #949

Conversation

tlaurion commented Jan 2, 2021 • edited Loading

bwachter commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021

tlaurion commented Jan 4, 2021 • edited Loading

bwachter commented Jan 5, 2021

tlaurion commented Jan 5, 2021 • edited Loading

bwachter commented Jan 5, 2021

tlaurion commented Jan 5, 2021

tlaurion commented Jan 17, 2021 • edited Loading

tlaurion commented Feb 9, 2021

tlaurion commented Feb 9, 2021

tlaurion commented Jun 27, 2021

MrChromebox commented Jun 28, 2021

tlaurion commented Aug 9, 2021

tlaurion commented Jan 2, 2021 •

edited

Loading

tlaurion commented Jan 4, 2021 •

edited

Loading

tlaurion commented Jan 5, 2021 •

edited

Loading

tlaurion commented Jan 17, 2021 •

edited

Loading