Occasional UNIT_GpsSensor_TEST failure

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Occasional UNIT_GpsSensor_TEST failure in Jenkins (the following build did not fail). It has the following console error:

103: [==========] Running 1 test from 1 test case.
103: [----------] Global test environment set-up.
103: [----------] 1 test from GpsSensor_TEST
103: [ RUN      ] GpsSensor_TEST.CreateGps
103: UNIT_GpsSensor_TEST: /usr/include/boost/smart_ptr/shared_ptr.hpp:424: T* boost::shared_ptr<T>::operator->() const [with T = gazebo::sensors::Noise]: Assertion `px != 0' failed.
103: [Msg] �Waiting for master.�
103: ��[Msg] �Connected to gazebo master @ �http://127.0.0.1:11345�
103: ��[Msg] �Publicized address: �192.168.1.196�
103: ���[Dbg] ��[��ServerFixture.cc��:��144��] ��ServerFixture load in ��1.1�� seconds, timeout after ��600�� seconds
103: ��[Dbg] ��[��ServerFixture.cc��:��95��] ��ServerFixture::Unload��
103: ���
103/130 Test #103: UNIT_GpsSensor_TEST ....................***Exception: Other 10.94 sec

It happens very early in the test. A backtrace on my mac (where it fails very consistently) implicates the following line in GpsSensor::UpdateImpl:

-> 142 	      gpsVelocity.x = this->horizontalVelocityNoise->Apply(gpsVelocity.x);

The noise data structures get allocated in GpsSensor::Load as of pull request #936, so I'm guessing that the Sensor update loops are being started before everything has loaded properly.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

I see the problem and will submit a pull request shortly.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

pull request #978

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• changed state from "new" to "resolved"

Pull request #978

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "resolved" to "closed"