Deprecate Get/Set High/Low Stop functions in Joint.

[osrf-migration]

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).

---

The functions mentioned in the title have been soft-deprecated. The comments say they are deprecated, but they have not been properly marked as deprecated.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

The comments aren't telling the whole story. They say GetUpperLimit and GetLowerLimit should be used instead. I think that is probably a better name for the functions, since it's nice to have the same number of letters in parter function names, so they're easier to read on adjacent lines.

The High/Low stop functions aren't ready to be deprecated yet, though since they are virtual, while the Upper/Lower Limit functions exist only in Joint. There is no BulletHingeJoint::SetUpperLimit for example.

This would improve the function names in the API, but it will take some extra work before they can be deprecated.

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[osrf-migration]

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

---

• set assignee_account_id to "557058:6ff86fcb-b7ab-44a5-b8a6-f6d9cae8b6e8"
• set assignee to "chapulina (Bitbucket: chapulina, GitHub: chapulina)"

[osrf-migration]

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

---

pull request #2568

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "new" to "resolved"

Resolved in pull request #2568

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "resolved" to "closed"