Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer more alignment options #1242

Open
osrf-migration opened this issue Jul 29, 2014 · 14 comments
Open

Offer more alignment options #1242

osrf-migration opened this issue Jul 29, 2014 · 14 comments
Labels
all enhancement New feature or request gui major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steffi Paepcke (Bitbucket: spaepcke).


In snap/align user study, when aligning wheel to chassis, the wheel aligned on the inside of the chassis, rather than on the outside. We should offer more alignment options.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Right now we offer 3 alignment options per axis. If we're aligning to 1st selected:

  1. min: align min of 2nd selected to min of 1st selected

  2. max: align max of 2nd selected to max of 1st selected

  3. center: align center of 2nd selected to center of 1st selected

We could add a button which, if checked, changes the behavior of min and max to:

  1. min: align max of 2nd selected to min of 1st selected

  2. max: align min of 2nd selected to max of 1st selected

Not sure what would be written / pictured on that button though.

@osrf-migration
Copy link
Author

Original comment by William Woodall (Bitbucket: William Woodall, GitHub: wjwwood).


When I mentioned the button I was thinking of this button from Solidworks' mate system:

http://blogs.solidworks.com/tech/wp-content/uploads/sites/4/MateAlignment.png

I think their iconography makes sense there, and it does what you've described (I think). One potential difference is that in Solidworks they actually rotate the part along a coplanar axis so that it's still the same two faces which are being snapped together, just rotated so that the rest of the object projects one way or the other.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Yeah, the icons are really clear there.

You're right about the difference, my suggestion doesn't involve rotating a part. Rotating things to face each other in the realm of Gazebo is closer to "snap" than "align" right now.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


I implemented what I suggested in a branch, let me know what you think:

https://youtu.be/5WZ6bZaHlJk

@osrf-migration
Copy link
Author

Original comment by Steffi Paepcke (Bitbucket: spaepcke).


That looks awesome! I definitely support adding that.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


I'll prepare a pull request. Let me know if you'd like to use an icon or change the word "inverted", add a tooltip or something like that.

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


it would also be nice to be able to:

  • align min/max of 2nd to center of 1st..

future work

@osrf-migration
Copy link
Author

Original comment by Steffi Paepcke (Bitbucket: spaepcke).


@chapulina Does this Solidworks explanation pertain to our version, or is it different? http://help.solidworks.com/2013/English/SolidWorks/sldworks/c_Mate_Alignment_SWassy.htm

If so, perhaps a similar icon would be good.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Not really. We're not handling faces and normals here. Instead, we're getting the rightmost point of one model and bringing it to the rightmost / leftmost point of another and so on. Which doesn't involve rotating the models. Does that make sense?

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


pull request #2040

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Now that pull request #2040 has been merged, what remains to be done?

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


A nice new feature would be to align in a model's local frame rather than the world frame.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • Edited issue description* set component to "gui"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all enhancement New feature or request gui major
Projects
None yet
Development

No branches or pull requests

1 participant