Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Laser visualization changed by pull request #1567 #1576

Closed
osrf-migration opened this issue Apr 24, 2015 · 6 comments
Closed

Laser visualization changed by pull request #1567 #1576

osrf-migration opened this issue Apr 24, 2015 · 6 comments
Labels
all bug Something isn't working major rendering

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


pull request #1567 fixed #124 by reporting out of range RaySensor measurements at +inf rather than the max range of the sensor. This has caused our RaySensor visualization to change:

pr2_raysensor_vis.png

This looks kinda cool, but it's different than it was before. I'm cc'ing @spaepcke to get her feedback on what we want it to look like.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Here's what it looks like in gazebo5 for reference:

pr2_raysensor_vis5.png

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Maybe we could use different colors for detected and undetected rays?

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set assignee_account_id to "557058:095b1e12-74ed-4e20-b44f-2f0745b616e0"
  • set assignee to "nkoenig (Bitbucket: nkoenig, GitHub: nkoenig)"

See pull request #1607

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

pull request #1607

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "resolved" to "closed"

@osrf-migration osrf-migration added major rendering bug Something isn't working all labels Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
all bug Something isn't working major rendering
Projects
None yet
Development

No branches or pull requests

1 participant