Visual transparancy behavior on gazebo6 and default

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

I was recently trying to merge gazebo6 forward to default and I found some conflicts in Visual class. I tried resolving those conflicts in the gazebo6_to_default branch, which I think is pretty similar to @iche033 's derived_transparency branch from the declined pull request #1987, though I added and modified a couple expectations in the ChildTransparency portion of Visual_TEST.cc. There is currently one failing expectation in the test, though, at line 420.

It's one of the few places where SetTransparency is tested with cascade=false, and it's unclear to me what the expected behavior should be.

I discussed this with @chapulina a bit, but I'll step aside so the rendering masters can sort it out.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

I forgot to mention I started a jenkins job for the gazebo6_to_default branch. It should confirm the failing expectation in UNIT_Visual_TEST.

[osrf-migration]

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

---

The cascade parameter for transparency was added in pull request #1851, but maybe it doesn't make sense to ever set it to false.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

test failure confirmed

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Another build:

• http://build.osrfoundation.org/view/gazebo/job/gazebo-any-devel-trusty-amd64-gpu-nvidia/691/

[osrf-migration]

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

---

I decided to follow ogre's node api where cascade is always true for SetTransparency, and keep cascade option only for SetVisible. There is also a InheritTransparency function that allows users to control if children's transparency will be affected by the parent.

pull request #2031

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• changed state from "new" to "resolved"

pull request #2031

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "resolved" to "closed"