ContactManager::CreateFilter() and ContactManager::RemoveFilter() are inconsistent
#1805
Comments
|
Original comment by Elte Hupkes (Bitbucket: ElteHupkes). Suggested fix: https://bitbucket.org/ElteHupkes/gazebo/commits/9649107ad71811ea38b96db647b8150defc5e4a9 |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). I'm just getting around to working with the contact manager, and I noticed this issue. Thanks for the report and suggested fix! I've written a failing test to confirm the issue in 6e5496c (branch |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). jenkins build confirming test failure: |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). potential fix in c4774ec |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). new build queued in http://build.osrfoundation.org/job/gazebo-ci-pr_any-xenial-amd64-gpu-none/64 |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters). fix in pull request #2363 |
|
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
|
|
Original comment by Nate Koenig (Bitbucket: Nathan Koenig).
|
Original report (archived issue) by Elte Hupkes (Bitbucket: ElteHupkes).
When creating a contact filter through
ContactManager::CreateFilter(), it performs a string replace to change all "::" to "/". However,ContactManager::RemoveFilter()does not do the same thing. This means that whenever a filter is created where the name has "::" in it, a call toRemoveFilterwith the same name does not remove it.As it so happens the
ContactSensoradds such a filter - when such a sensor is removed its contact filter lingers.The text was updated successfully, but these errors were encountered: