Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost signals library removed in boost 1.69 #2577

Closed
osrf-migration opened this issue Dec 13, 2018 · 3 comments
Closed

boost signals library removed in boost 1.69 #2577

osrf-migration opened this issue Dec 13, 2018 · 3 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


The boost signals library was deprecated in 1.54 in favor of the signals2 code, which is header-only. The signals library is removed in boost 1.69, which was just released and is being tested in homebrew:

With boost 1.69, gazebo fails to find boost during configuration, as it searches for the signals component.

I'm not sure when boost 1.69 will be merged into homebrew, but it will break gazebo on homebrew when it does. We should try to fix this before that is merged if possible. If an API/ABI compatible patch is not possible; we can consider maintaining a boost@1.68 bottle in our tap, but I would really not want to do that.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


It's possible that we're not even using it anymore and just need to remove signals from the find_package call

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


removing signals from find_package call in pull request #3050

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

pull request #3050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant