Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazebo does not have relocatable CMake configuration files #2755

Closed
traversaro opened this issue Jun 11, 2020 · 0 comments · Fixed by #2879
Closed

Gazebo does not have relocatable CMake configuration files #2755

traversaro opened this issue Jun 11, 2020 · 0 comments · Fixed by #2879

Comments

@traversaro
Copy link
Collaborator

traversaro commented Jun 11, 2020 •
edited
Loading

See https://cmake.org/cmake/help/v3.15/manual/cmake-packages.7.html#creating-relocatable-packages for a definition of relocatable CMake configuration files. In a nutshell, it means that you can move the installation directory of Gazebo after Gazebo has been installed, and Gazebo and consuming Gazebo libraries from CMake continue to work correctly.

This is a known issue that I do not know if it feasible/it make sense to address for Gazebo Classic. However, I think it make sense to have a reference issue for this, so that we have an issue to refer to when implementing workarounds for this problems.
@traversaro traversaro mentioned this issue Jul 9, 2020
Closed
Pro added a commit to Pro/gazebo that referenced this issue Nov 17, 2020
@Pro
fix: Use proper cmake package config for relocatable CMake config
6f92033 
The CMake config used absolute paths which doesn't allow to move the installed cmake files. This is the case, e.g., if you create a conan package and distribute the binaries to other users.

Fixes: gazebosim#2755
Fixes: gazebosim#2782
Pro added a commit to Pro/gazebo that referenced this issue Nov 17, 2020
@Pro
fix: Use proper cmake package config for relocatable CMake config
926fe5a 
The CMake config used absolute paths which doesn't allow to move the installed cmake files. This is the case, e.g., if you create a conan package and distribute the binaries to other users.

Fixes: gazebosim#2755
Fixes: gazebosim#2782
Pro added a commit to Pro/gazebo that referenced this issue Nov 17, 2020
@Pro
fix: Use proper cmake package config for relocatable CMake config
adb54b5 
The CMake config used absolute paths which doesn't allow to move the installed cmake files. This is the case, e.g., if you create a conan package and distribute the binaries to other users.

Fixes: gazebosim#2755
Fixes: gazebosim#2782
@Pro Pro mentioned this issue Nov 17, 2020
Merged
Pro added a commit to Pro/gazebo that referenced this issue Nov 17, 2020
@Pro
fix: Use proper cmake package config for relocatable CMake config
605be53 
The CMake config used absolute paths which doesn't allow to move the installed cmake files. This is the case, e.g., if you create a conan package and distribute the binaries to other users.

Fixes: gazebosim#2755
Fixes: gazebosim#2782
@traversaro traversaro mentioned this issue Feb 3, 2021
Open
j-rivero pushed a commit that referenced this issue Mar 15, 2021
@Pro @scpeters
Ensure relocatable package config files (#2879)
2df3bfb 
* fix: Use proper cmake package config for relocatable CMake config
* Fix relative path in pkg-config files

The CMake config used absolute paths which doesn't allow to move the installed cmake files. This is the case, e.g., if you create a conan package and distribute the binaries to other users.

Fixes: #2755
Fixes: #2782

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure relocatable package config files Pro/gazebo
1 participant
@traversaro