Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup.sh] preserve GAZEBO_MASTER_URI if set #2737

Merged

Conversation

moriarty
Copy link
Contributor

If GAZEBO_MASTER_URI is set use that otherwise use the default.

Most of the environment variables set in setup.sh already preserve or append to values which were already set.

Example use case:
If you want to run gzserver and gzclient in two different containers. You would first start the gzserver and then pass the GAZEBO_MASTER_URI to the docker run -e for the gzclient which could now source setup.sh without needing it's own custom entrypoint.

The only environment variable in setup.sh which does not preserve or append is GAZEBO_MODEL_DATABASE_URI - I imagine it may be worth doing the same change to that variable too.

If GAZEBO_MASTER_URI is set use that otherwise use the default.
@moriarty
Copy link
Contributor Author

wow that's a lot of ✖️ checks failing

@j-rivero j-rivero self-assigned this Jun 12, 2020
@j-rivero
Copy link
Contributor

@osrf-jenkins run tests please

@j-rivero
Copy link
Contributor

all builds are UNSTABLE (expected at this moment) and test failures are not relevant to this PR as far as I can see.

I thought the change would bring some bash particular syntax to the file but seems like variable default values are in the posix standard, good.

@j-rivero
Copy link
Contributor

Thanks @moriarty ! I final request, could you please update the Changelog.md file with an entry about this change?

@j-rivero
Copy link
Contributor

Thanks Alex!

@j-rivero j-rivero merged commit 7200818 into gazebosim:gazebo11 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants