-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple reflectance maps and improve performance #2742
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
cc @ahcorde |
On my desktop
After:
|
Changelog.md
Outdated
## Gazebo 9.XX.X (20XX-XX-XX) | ||
|
||
1. Fix multiple reflectance maps and improve performance | ||
* [Pull request ]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [Pull request ]() | |
* [Pull request](https://github.com/osrf/gazebo/pull/2742/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. e6a2f94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor fix in the changelog
it looks fine to me. the windows build failure is unrelated |
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Changes
Fixes issue when there are multiple objects in the scene with different reflectance maps by creating a unique reflectance material for each reflectance map
Improves performance by disabling shadows during reflectance render updates.
Testing
Build this branch with gazebo_ros_pkgs
noetic-devel
branchHere is a reflectance_test.world for testing. The world consists of 3 depth cameras with depth, normals, reflectance output, and 100 boxes in front of the depth cameras.
For verifying multiple reflectance maps, launch gazebo with the
reflectance_test.world
:launch
rqt_image_viewer
to see data from the reflectance topic:You should see two different reflectance maps rendered side by side. Before the changes in the PR, I see two identical reflectances maps.
For testing performance, launch the
reflectance_test.world
, and see the frame rates usingrostopic hz
. Subscribe to all 3 depth cameras:The target framerate is set to 30Hz but the cameras do not hit the target frame rate (which is what we want for testing so we can see the differences in performance). These are the frame rates I get on my laptop before and after the change:
Before:
After:
In two cases that refletance is enabled, the frame rate improves by 5~7Hz
Signed-off-by: Ian Chen ichen@osrfoundation.org