DARTHeightmapShape: correctly load asymmetric terrains #2818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for heightmaps in DART was added in bitbucket pull request 2956 and bitbucket pull request 3066 with tests using the heightmap_valley.png image, which happens to be symmetric in both x and y directions. I recently noticed a bug in DARTHeightmapShape when using asymmetric terrains, so I added a test using worlds/heightmap.world, which uses the asymmetric heightmap_bowl.png with a box at each of the 4 corners. The boxes all start at the same height, and based on the shape of the heightmap, 3 of the boxes should already be in contact with the heightmap, but one of them (
box2
) should fall. I've added a test that illlustrates the failure with dart:The fix is to set an uninitialized variable
DARTHeightmapShape::flipY
to false.Use
gazebo --verbose worlds/heightmap.world -e dart
to see the failure in gzclient.