Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gazebo 9] Added Profiler to gazebo::rendering #2836

Merged
merged 5 commits into from
Oct 3, 2020
Merged

[Gazebo 9] Added Profiler to gazebo::rendering #2836

merged 5 commits into from
Oct 3, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 31, 2020

Added profiler to gazebo::rendering

Selección_053

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Added Profiler to gazebo::rendering
dec5a11 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added enhancement New feature or request 9 Gazebo 9 labels Aug 31, 2020
@ahcorde ahcorde requested review from iche033 and chapulina August 31, 2020 09:31
@ahcorde ahcorde self-assigned this Aug 31, 2020
@chapulina
Copy link
Contributor

It looks like a compiler warning slipped in with #2813 , we could fix it now:

RemoteryConfig.h:8
"RMT_USE_OPENGL" redefined #define RMT_USE_OPENGL 1

@chapulina
fix warning
ab3094c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

This PR is behind #2837 . Once that goes in, this one should be updated.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 2, 2020

@chapulina updated with the last changes in Gazebo 11 PR

@j-rivero
Copy link
Contributor

j-rivero commented Oct 2, 2020

@osrf-jenkins run tests please

chapulina
chapulina approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some minor comments which we can fix before merging. CI is running and should be done in a couple hours.

gazebo/sensors/CameraSensor.cc Outdated Show resolved Hide resolved
gazebo/sensors/MultiCameraSensor.cc Outdated Show resolved Hide resolved
gazebo/sensors/GpuRaySensor.cc Outdated Show resolved Hide resolved
gazebo/rendering/skyx/src/VCloudsManager.cpp Outdated Show resolved Hide resolved
@chapulina
small tweaks
f37f348 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

It looks like a compiler warning slipped in with #2813 , we could fix it now:

My fix on ab3094c worked locally, but the warning is still on CI. Since it's not introduced by this PR, I don't think it should prevent merging it.

@chapulina chapulina merged commit ce6570f into gazebo9 Oct 3, 2020
@chapulina chapulina deleted the ahcorde/profiler/rendering branch October 3, 2020 00:16
@chapulina chapulina mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033

Assignees

@ahcorde ahcorde

Labels
9 Gazebo 9 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @chapulina @j-rivero