This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Fix ogre log test #2840
Merged
Fix ogre log test #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
@osrf-jenkins run tests please |
|
ogre log test no longer fails in latest windows build |
|
Not sure about the impact of the change in current Gazebo installations. If it is not only used in tests, we might want to add a Changelog entry. Otherwise I don't see a negative effect in the tests. |
j-rivero
approved these changes
Sep 9, 2020
The material was recently added in pull request #2833 and that not been released yet so I think there won't be a negative impact with this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightingis specified in the wrong place but turns out the reflectance data generated are correct without this flag so it's removed.Signed-off-by: Ian Chen ichen@osrfoundation.org