This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Add mutex to make Sensor::SetActive threadsafe #2871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsActive
function in the Sensor class is being called from various threads, e.g. rendering, physics (event callback from physics), and transport threads. So a mutex is added to protects calls for setting theactive
variable inSensor
class so that it is safe to callSetActive
from gazebo plugins, e.g. various plugins in gazebo_ros_pkgs calls SetActive to enable / disable the sensors when subscriber count changes.Signed-off-by: Ian Chen ichen@osrfoundation.org