This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Fix namespace usage in console macros #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuettner
force-pushed
the
fix_namespace_in_console_macros
branch
from
7dd3d39 to
7c8831a
Compare
|
Interesting, thank you for the fix. Do you think you could add a test case that wouldn't compile without the fix?
Yeah that would be great. We can backport this to |
|
Yes, I'll add a regression test. I also opened up an issue as a test reference. |
added 2 commits
December 1, 2020 16:02
This code did not work
```cpp
namespace foo::gazebo
{
class bar
{
public:
void doSomething() {
gzmsg << "doSomething" << std::endl;
}
};
} // foo::gazebo
```
because gzmsg resolves to (gazebo::common::Console::msg()).
It results in this error:
```
error: ‘foo::gazebo::common’ has not been declared
#define gzmsg (gazebo::common::Console::msg())
```
stefanbuettner
force-pushed
the
fix_namespace_in_console_macros
branch
from
7c8831a to
9ff7bc0
Compare
scpeters
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
This code did not work
because gzmsg resolves to (gazebo::common::Console::msg()) which
resolves in this error:
Should this also be fixed in older gazebo version?
This solves #2896
Cheers,
Stefan
cc @Pro