Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port #2789: windows fixes #2985

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented May 2, 2021

Based on #2789

Fixes #2611

Thanks to @traversaro for catching this.

I think this is ready to go.

@Tobias-Fischer Tobias-Fischer changed the title [WIP] Forward port #2789 Forward port #2789 May 2, 2021
@scpeters scpeters changed the title Forward port #2789 Forward port #2789: windows fixes Oct 27, 2021
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters merged commit 17092b6 into gazebosim:gazebo11 Oct 28, 2021
@Blast545
Copy link

👨‍🌾 This PR seems to have introduced a build regression in the MacOS buildfarm.

/Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/sensors/GaussianNoiseModel.cc:222:7: error: use of undeclared identifier 'math'; did you mean 'ignition::math'?
  if(!math::equal(0.0, this->biasStdDev))
      ^~~~
      ignition::math

Can you take a look @scpeters @Tobias-Fischer ?

https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/106/consoleFull

@scpeters
Copy link
Member

👨‍🌾 This PR seems to have introduced a build regression in the MacOS buildfarm.

Can you take a look @scpeters @Tobias-Fischer ?

https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/106/consoleFull

I made a mistake in c65a745 but fixed it in #3128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo9][Windows] ModelDatabase::GetModelPath implementation is incomplete on Windows build.
3 participants