Distortion camera initialization fix #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the initialization of cameras with distortion. Loading multiple cameras with different distortion parameters at the same time causes some of the same distortion parameters to be applied to all those cameras. Spawning a model with a single distorted camera afterwards works fine, even in a world that already contains distorted cameras. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…n cameras Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
|
a 3 line fix! |
|
it looks like this fix works; it doesn't have a regression test, but I'd like to merge this and get it released to unblock users who need it. I will keep the underlying issue open until we have merged a regression test |
scpeters
approved these changes
Jun 28, 2021
iche033
approved these changes
Jun 28, 2021
This was referenced Jun 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2527 - Last camera's distortion affects previous cameras' distortions
When loading multiple cameras on the application startup, each camera would finish initialization but their compositor's material would only be set after every camera has been initialized. This would make all compositor materials to be set to the most recently initialized camera.
To fix this issue,
the compositor material should be set right after their camera is done initializingrather thanwaiting for all the cameras to finish initialization.