This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Faster examples build test and other CI fixes #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
They currently fail, so just skip them for now. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Use default constructor instead of passing 0. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Use angleDelta().y() instead of delta() Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EXAMPLES_examples_buildtest has been timing out on Ubuntu CI machines recently, as documented in #3079. Its timeout has already been extended from 240 to 500 seconds, but this is apparently not enough. This PR includes a quick attempt to speed up compilation usingmake -jin the test (b1d13f4).This includes several other CI fixes as well:
Qt::KeyboardModifiers()constructor explicitly instead of passing in integer0angleDelta().y(), which assumes the vertical scroll component