Always publish if flag is passed to Model::SetScale #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Model::SetScale does nothing if the new scale is approximately equal to the current scale, even if the _publish flag is set to true. This change ensures that the scale is always published if the flag is set. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Expect new ~/model/info messages to be passed for each call to SetScale if publish flag is set, even if the scale value is not different. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
cc @mogumbo |
|
diff without whitespace: https://github.com/osrf/gazebo/pull/3116/files?w=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Model::SetScaledoes nothing if the new scale is approximately equal to the current scale, even if the_publishflag is set to true. This change ensures that the scale is always published if the flag is set.