Revert boost/bind.hpp changes in header files and bump to 11.10.1 #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the includes can break downstream software, so let's revert this for now. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
changed the title
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
Jan 14, 2022
|
I might have missed something here... Does this revert fix something? Before the boost::bind changes there wasn't actually anything broken downstream (e.g. in the AUR package I maintain), just a lot of log spam from harmless deprecation warnings, but it seemed like a sensible thing to fix. |
|
If this fix no longer works, would it be possible to merge my (now-closed) PR #3147 instead? That would at least get rid of the log spam (which can make it harder to debug other issues). |
Define this symbol to fix warnings in the specific header files where we include boost/bind.hpp, which is more targeted than a -D compiler flag. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
does 1718514 work for you @alexdewar ? |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #3156 (comment), the changes in #3156 to header files have the potential to break downstream software. This pull request reverts the changes to header files and bumps the patch version to 11.10.1, so we can make a quick release and unbreak downstream software.
cc @traversaro (apologies to @alexdewar )
Update: I started wondering if this would affect gazebo_ros_pkgs, since I see
_1in gazebo_ros_api_plugin onnoetic-devel, but it didn't fail its latest CI job (using Ubuntu 20.04):I believe this is because
boost/thread.hppprovides an opportunistic include ofboost/bind.hppfor boost 1.72 and earlier (see boostorg/thread@boost-1.72.0...boost-1.73.0#diff-c94867ed785b09487490187250e85510d4ac8698e7fa22dc56906baeb83423d0L33), so this does not affect Ubuntu 20.04, which uses boost 1.71. That's also why the homebrew CI failed in #3156 but not the Ubuntu CI.So I still support the changes in this pull request, but I've convinced myself that it is not as dire as it sounded, since it does not affect Ubuntu 20.04.