Support plotting for entities with / in the name #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed while testing the rexrov models from the rexrov model in Field-Robotics-Lab/dave that the plotting window does not work properly when elements of a model include a forward-slash `/` in the entity name. To fix the problem, the `/` characters are encoded as %2f in physics::Base::URI(). Corresponding decoding is added to the gui/plot/Palette class. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
plot_names_with_slashes
branch
from
cc20b5e to
0dc1a39
Compare
I noticed a CI build failure with gcc-8 that doesn't occur with gcc-9. Try to avoid failure by using std::string's compare function instead of an == operator with a const char * string literal. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
Mar 7, 2022
gazebo/physics/Base.cc
Outdated
| @@ -383,15 +384,19 @@ common::URI Base::URI() const | |||
| { | |||
| if (p->GetParent()) | |||
| { | |||
| uri.Path().PushFront(p->GetName()); | |||
| std::string escapedParentName = p->GetName(); | |||
| boost::replace_all(escapedParentName, "/", "%2f"); | |||
There was a problem hiding this comment.
use common::replaceAll instead of boost? I do still see boost being used in gazebo so maybe not a big deal
There was a problem hiding this comment.
I switched to common::replaceAll in 7edb013
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This would prevent a string containing "%2f" from incorrectly being unescaped to "/". Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Mar 14, 2022
This fixes some downstream compilation issues. Follow-up to gazebosim#3187. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Mar 14, 2022
* Don't include TaskGroup.hh from transport.hh This fixes some downstream compilation issues. Follow-up to #3187. * check_test_ran: don't use grep Check the file for the desired string directly in python without using grep to improve Windows support. * Use python3 with check_test_ran.py for qt tests Follow-up to #3155. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while testing the rexrov models from
Field-Robotics-Lab/dave that the plotting window
does not work properly when elements of a model include
a forward-slash
/in the entity name. To fix the problem,the
/characters are encoded as %2f in physics::Base::URI().Corresponding decoding is added to the gui/plot/Palette class.
Fixes #3181.