Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Permit users to override USE_EXTERNAL_TINYXML2 and USE_EXTERNAL_TINYXML in CMake #3254

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

traversaro
Copy link
Collaborator

@traversaro traversaro commented Sep 3, 2022

The variables USE_EXTERNAL_TINYXML and USE_EXTERNAL_TINYXML2 could not be overridden with CMake cache variables set by the command line, this PR permit to override them to also use external tinyxml(2) library on Windows.

@traversaro traversaro force-pushed the fixwinexternaltinyxml branch from 39e1132 to 6e86dff Compare September 3, 2022 13:16
@traversaro traversaro changed the title Permit users to override USE_EXTERNAL_TINYXML2 and USE_EXTERNAL_TINYXML Permit users to override USE_EXTERNAL_TINYXML2 and USE_EXTERNAL_TINYXML in CMake Sep 3, 2022
@traversaro traversaro closed this Sep 3, 2022
@traversaro traversaro reopened this Sep 3, 2022
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@j-rivero j-rivero merged commit 51fd5fd into gazebosim:gazebo11 Sep 6, 2022
@traversaro
Copy link
Collaborator Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants