Skip to content

Choosing models with more recent sdf version #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
osrf-migration opened this issue Jun 3, 2016 · 4 comments
Closed

Choosing models with more recent sdf version #123

osrf-migration opened this issue Jun 3, 2016 · 4 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


There is logic in parser.cc for choosing which sdf version of a model to use when a model is specified with the <include><uri>model:// syntax. There is similar logic in gazebo that was updated in gazebo pull request 2207 and should be propagated to sdformat.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Porting the SemanticVersion class to ignition math in the following pull request:

This class is used by the patch to be added to sdformat.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


The patch is in c1f254c (branch issue_123)

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


See pull request #291. We still need to add a test for this. It could be adapted from gazebo pull request 2207

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 11, 2020
@scpeters
Copy link
Member

scpeters commented Jul 7, 2022

this feature is implemented

@scpeters scpeters closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

2 participants