Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broodoo Shield - Incorrect buy_limit #220

Open
tyler-shaw opened this issue May 20, 2021 · 1 comment
Open

Broodoo Shield - Incorrect buy_limit #220

tyler-shaw opened this issue May 20, 2021 · 1 comment
Assignees
Labels
bug data Label to identify updating or adding any data items Anything to do with the items data, API or builder

Comments

@tyler-shaw
Copy link

Hello. I've got a script that monitors changes in the data from the API and I noticed that Broodoo shields all have buy limits of null now. Previously, they were correctly listing the buy limit as 125.

I double checked the wiki, and each Broodoo shield still appears to be listing 125 as the buy limit.

For example, here's the green one on the API: https://api.osrsbox.com/items/6235
And the respective page on the wiki: https://oldschool.runescape.wiki/w/Broodoo_shield_(green)#Uncharged

Thanks!

@osrsbox osrsbox self-assigned this May 23, 2021
@osrsbox osrsbox added bug data Label to identify updating or adding any data items Anything to do with the items data, API or builder labels May 23, 2021
@osrsbox
Copy link
Owner

osrsbox commented May 23, 2021

Hey @tyler-shaw - after a quick look... yes you are correct. The uncharged variant should have a buy limit of 125. The charged version with 10 charges should also have a buy limit, but it also doesn't: https://api.osrsbox.com/items/6215
I get the buy limit data from the following wiki page: https://oldschool.runescape.wiki/w/Grand_Exchange/Buying_limits. Then match on item name, or wiki name
Looks like the manes in that table do not match the names used in the other wiki pages etc. Will have a little think about how to solve this without hardcoding heaps of stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data Label to identify updating or adding any data items Anything to do with the items data, API or builder
Projects
None yet
Development

No branches or pull requests

2 participants