You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We operate allstar inside a GHA with --once and noticed (due to #501) that a policy check would fail to apply at a certain point, but the app just exited with return code 0. It stopped monitoring for any more policies, but also didn't notify us of failure. The only way to notice is that the execution time of the GHA was much smaller than normal.
My initial thought was to update the goroutine to return the error, but realized this will also cancel the errgroup context and block any more app installations from running.
We could likely keep track of errors similar to how we keep track of failures, and do a check to return them after the fact. This can probably be opt-in behaviour if we are worried, but it might make sense to always be the behaviour for --once.
The text was updated successfully, but these errors were encountered:
We operate allstar inside a GHA with
--once
and noticed (due to #501) that a policy check would fail to apply at a certain point, but the app just exited with return code 0. It stopped monitoring for any more policies, but also didn't notify us of failure. The only way to notice is that the execution time of the GHA was much smaller than normal.My initial thought was to update the goroutine to return the error, but realized this will also cancel the
errgroup
context and block any more app installations from running.We could likely keep track of errors similar to how we keep track of failures, and do a check to return them after the fact. This can probably be opt-in behaviour if we are worried, but it might make sense to always be the behaviour for --once.
The text was updated successfully, but these errors were encountered: