Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors more granularly when polling for specific packages #107

Closed
tom--pollard opened this issue May 7, 2021 · 0 comments · Fixed by #123
Closed

Handle errors more granularly when polling for specific packages #107

tom--pollard opened this issue May 7, 2021 · 0 comments · Fixed by #123

Comments

@tom--pollard
Copy link
Contributor

tom--pollard commented May 7, 2021

With #99 landing, the ability to provide a specific set of packages for polling was added to the pypi feed, with the framework for this to be extended to other similar feeds.

This brings with it the caveat that if when polling a feed for any of the set of packages fails (e.g, network error/timeout), then the whole set of package data from that specific polling session is lost. This is due to the assumption from the generic polling of the 'firehose' that only one roundtrip will be performed, as oppose to the N that may be done if watching a given set of endpoints.

While it's right to report the error/errors, if a partial set of packages were successfully polled then it's reasonable to continue processing them and could be a candidate for the event framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant