Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Token-Permission check outputs wrong score #1400

Closed
laurentsimon opened this issue Dec 16, 2021 · 0 comments · Fixed by #1401
Closed

BUG: Token-Permission check outputs wrong score #1400

laurentsimon opened this issue Dec 16, 2021 · 0 comments · Fixed by #1401
Assignees
@laurentsimon
Labels
kind/bug Something isn't working

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Dec 16, 2021 •
edited
Loading

The Token-Permission check stores all wokflows' results in a single map. This mean we cannot differentiate between workflow files. Running scorecard on our repo returns 0. That's because we originally only looked for top-level permission being defined, but this recently changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentsimon laurentsimon

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix score calculation for multiple files laurentsimon/scorecard
1 participant
@laurentsimon