-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate between commit SHA and tag SHA #2132
Comments
This would be a nice improvement. Can you give an example repository? I'm not following the part that I've not fiddled much with annotated tags, so please bear with me :) |
If you take a look at the actions/checkout repository you’ll see that there is no commit I’m waiting for a response to that discussion in issue actions/checkout#874 (comment). |
Stale issue message - this issue will be closed in 7 days |
Uhm. Ping? |
This issue is stale because it has been open for 60 days with no activity. |
Yes, this would entirely defeat the purpose of a pinned GitHub Action. Hmm, this is similar to #2733, and a result of a GitHub implementation detail. @laurentsimon I'm curious if we should have these API intensive tasks available as additional probes for people to run when needed, just not by default. |
+1 on having a probe for it. |
This issue is stale because it has been open for 60 days with no activity. |
Is your feature request related to a problem? Please describe.
Related to my question/issue actions/checkout#874. As described there, we had pinned an Action like so:
where
d065129
was an annotated tag namedv3
and not an existing commit. Furthermore, folks rewrite that tag whenever a new version 3 is released so that that “pin” isn’t really a pin at all.Describe the solution you'd like
Warn me if a SHA is not a commit SHA, i.e. if the pin can be redirected.
Describe alternatives you've considered
Manually cross-checking that the pinned Actions actually reference commit SHAs.
Additional context
Pretty please?
The text was updated successfully, but these errors were encountered: