Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Implement GitLab Native License Check for GitLab Hosted Projects #2517

Closed
shissam opened this issue Dec 2, 2022 · 2 comments
Closed
Assignees
Labels
kind/enhancement New feature or request

Comments

@shissam
Copy link
Contributor

shissam commented Dec 2, 2022

Is your feature request related to a problem? Please describe.
The License check was improved to provide more details as to the nature of the license selected for a given project. This improvement used GitHub's License API to get those details. These improved details should also be available for GitLab hosted projects (and scored accordingly).

Describe the solution you'd like
clients/gitlabrepo/licenses.go should behave in a like manner as clients/githubrepo/licenses.go where possible applying the same semantic results as returned by the GH API and the builtin heuristics used by scorecard when an API is not available.

Describe alternatives you've considered
PR #2442 implemented an improved builtin heuristic for better identification of the license selected for a given project but does not actually open the identified license file to attest to that license selected (but rather naming conventions, which is unlike the GH API which performs such content analysis). That builtin heuristic is only used when the hosting repository does not have an License API endpoint for getting that information--and is therefore slower and potentially not as accurate. Although the builtin heuristic should work on GitLab hosted projects, use of a GitLab License API endpoint, would be a better choice.

Additional context
Add any other context or screenshots about the feature request here.

@shissam shissam added the kind/enhancement New feature or request label Dec 2, 2022
@github-actions
Copy link

Stale issue message - this issue will be closed in 7 days

@spencerschrock
Copy link
Member

Completed as part of #3413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants