Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Commit-Depth Not Used on Querying Gitlab #2828

Closed
jimrobison opened this issue Apr 5, 2023 · 0 comments · Fixed by #3672
Closed

BUG: Commit-Depth Not Used on Querying Gitlab #2828

jimrobison opened this issue Apr 5, 2023 · 0 comments · Fixed by #3672
Labels
gitlab Issue related to Scorecard's GitLab client kind/bug Something isn't working

Comments

@jimrobison
Copy link
Contributor

Describe the bug
The new gitlab functionality is not using the parameter --commit-depth in querying the gitlab repo for commits. In addition the defaulted value of 30 was not being used either, for the same reason.

Reproduction steps
Steps to reproduce the behavior:

  1. Provide a --commit-depth on command line go run main.go --repo=gitlab.com/hoppr/hoppr --commit-depth 200
  2. Counting commits there are only 20 (gitlab's default) (print out and/or debugger)

Expected behavior
As a user providing the --commit-depth, I would expect that correct number of commits being evaluated/scored. I also expect that I don't provide a value, I'd expect the documented default of 30 to be used.

@jimrobison jimrobison added the kind/bug Something isn't working label Apr 5, 2023
@raghavkaul raghavkaul added the gitlab Issue related to Scorecard's GitLab client label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitlab Issue related to Scorecard's GitLab client kind/bug Something isn't working
Projects
None yet
2 participants