Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add woodpecker as known CI #4336

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

6543
Copy link
Contributor

@6543 6543 commented Sep 4, 2024

What kind of change does this PR introduce?

It addresses #4210

What is the current behavior?

It does not count tests run by Woodpecker
e.g. CI-Tests score of woodpecker's own main repo is 8/10

What is the new behavior (if this is a feature change)?**

it detects woodpecker and score the tests acordingly
e.g. CI-Tests score of woodpecker's own main repo is 10/10

scorecard --repo=https://github.com/woodpecker-ci/woodpecker :
image

Which issue(s) this PR fixes

Fixes #4210

Special notes for your reviewer

Does this PR introduce a user-facing change?

no

Signed-off-by: 6543 <6543@obermui.de>
@6543 6543 requested a review from a team as a code owner September 4, 2024 21:52
@6543 6543 requested review from justaugustus and raghavkaul and removed request for a team September 4, 2024 21:52
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good thanks! One quick question

probes/testsRunInCI/impl.go Outdated Show resolved Hide resolved
@spencerschrock
Copy link
Contributor

/scdiff generate CI-Tests

Copy link

probes/testsRunInCI/impl.go Outdated Show resolved Hide resolved
Signed-off-by: 6543 <6543@obermui.de>
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Can you update your branch?

Either via rebase or merge is fine, we squash to merge in the end.

@6543
Copy link
Contributor Author

6543 commented Sep 11, 2024

Done

@spencerschrock spencerschrock enabled auto-merge (squash) September 11, 2024 07:47
@spencerschrock spencerschrock merged commit 6d9b2e4 into ossf:main Sep 11, 2024
36 checks passed
@6543 6543 deleted the detect-woodpecker-as-ci branch September 11, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature: Recognize Woodpecker-CI as a well-known CI
2 participants