Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review content and PR process Criteria #41

Open
dcmiddle opened this issue Feb 18, 2021 · 2 comments
Open

Review content and PR process Criteria #41

dcmiddle opened this issue Feb 18, 2021 · 2 comments

Comments

@dcmiddle
Copy link

The project should consider adding PR criteria including process criteria like maintainer diversity and minimum duration for receiving feedback.
The goal should be to set a bar for valuable content that is equitably reviewed.
The higher quality the content the more valuable this project will be to the community.

@scovetta
Copy link
Contributor

I can definitely get behind a minimum duration for receiving feedback -- does a week sound reasonable to you? And worst case, feedback can always come in afterwards.

Re: maintainer diversity -- I think this would penalize "single developer" projects -- the goal of this project isn't really to describe project health (something like the OpenSSF Scorecards project would provide that information). Unless I've misunderstood what you mean here.

@dcmiddle
Copy link
Author

dcmiddle commented Feb 19, 2021

Sorry there's a lot of overloaded words here talking about reviews of security reviews. :)
Regarding maintainer diversity I meant for this security-reviews project, i.e. a PR should require two different security-reviews maintainers approving the PR before it is merged.

And yes I think 1 week sounds good. enough time for interested parties to have seen something and not too long to slow down progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants