Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab support #20

Open
1 of 3 tasks
bacharakis opened this issue Jun 10, 2019 · 2 comments
Open
1 of 3 tasks

Add GitLab support #20

bacharakis opened this issue Jun 10, 2019 · 2 comments
Assignees
Milestone

Comments

@bacharakis
Copy link
Contributor

bacharakis commented Jun 10, 2019

  • Research, identify and select a client library for fetching GitLab issue.
  • Implement code changes
  • Review and testing
@bacharakis bacharakis added this to the CEIDAS milestone Jun 10, 2019
@kounelisagis
Copy link
Member

kounelisagis commented Jul 1, 2019

Update - July 1st

We already have a client library to send requests to the GitHub API using GraphQL
(https://github.com/shurcooL/githubv4). So we need something similar for GitLab API. Unfortunately there is no such library for GitLab. Therefore we are going to use the classic GitLab RESTful API (https://docs.gitlab.com/ee/api/README.html).

Future Updates

When GitLab GraphQL API becomes available we can replace the specialized version of the client library, targeting only GitHub, with the universal version: https://github.com/shurcooL/graphql. In this way we can call both APIs in a similar way using just one universal GraphQL library. Furthermore, the current source code is expandable because the new library is just the generalization of the old. Only few changes are needed.

@kounelisagis
Copy link
Member

kounelisagis commented Jul 11, 2019

Update - July 12

The changes can be viewed here: https://github.com/kounelisagis/fixme_backend/tree/gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants