Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to auto-generate code for more direct libostree api usage #11

Open
sjoerdsimons opened this issue Jul 27, 2017 · 1 comment
Open

Comments

@sjoerdsimons
Copy link
Contributor

Hey,

So i've been playing a bit with ostree-go, getting it to implement just enough for my use-case (which is to build images really). Part of doing so made me understand the project a bit better, which led me to some questions.

One thing that was somewhat surprising to me is that it's not just (or at least has) a small wrapper around libostree directly to make the same API usable from Go but more modelled after the various ostree builtin commands, which is not unreasonable but when ostree is becoming libostree the former may make more sense :).

But that also made me wonder whether the option of autogenerating the bindings via go-gir-generator was evaluated? Writing them by hand tend to be somewhat cumbersome and error-prone (fwiw the current code leaks in quite a few places as it doesn't free C.CString results nor seems to handle gobject lifetimes). (I'm somewhat surprised that gogtk3 is seemingly handwritten as well..)

Would there be an interest in e.g. a gir-go-generator based libostree binding to rebase the potentially useful convenience layers on top or does that not fit within the scope of this project?

@ashcrow
Copy link
Contributor

ashcrow commented Jun 18, 2018

Some interesting generation utilities:

It would seem to me that generation plus some and clean up to pretty up bindings would be easier to maintain. @cgwalters WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants