feat: implement stores-no-async
#225
Conversation
🦋 Changeset detectedLatest commit: 0b8b4ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
Thank you for this PR!
I think it works mostly fine already, but I have some change requests to address some edge cases.
src/rules/no-store-async.ts
Outdated
| if (name !== "writable" && name !== "readable" && name !== "derived") | ||
| return | ||
| const [, fn] = node.arguments | ||
| if (fn.type !== "ArrowFunctionExpression" || !fn.async) return |
There was a problem hiding this comment.
I think we should check if the argument exists.
| if (fn.type !== "ArrowFunctionExpression" || !fn.async) return | |
| if (!fn || fn.type !== "ArrowFunctionExpression" || !fn.async) return |
There was a problem hiding this comment.
fixed! Sorry for that!
|
Thank you for your review! |
JounQin
left a comment
JounQin
left a comment
There was a problem hiding this comment.
I don't see anything strange. LGTM! 🍺
|
Thank you for your contribution! |
4 participants
Related to: #198 (
stores-no-async)This is the first ESLint rule I have written.
(So I'm sorry if I have a wrong understanding.)
I would be very grateful if you would review it.