A 'declare' modifier cannot be used in an already ambient context

[whitlockjc]

As reported in whitlockjc/json-refs#140, it seems like a declare in a module, namespace, ... causes the error thrown in the title. whitlockjc/json-refs#143 shows how to fix this and has some details.

[wehrstedt]

Can you give me an example of the input, the output and what you expect it should look like?

[whitlockjc]

https://github.com/whitlockjc/json-refs is a perfect example. index.js and lib/typedefs.js end up creating the TypeScript definitions in index.d.ts. What happens is if you have a @typedef {object} that is a @memberof module:json-refs, when the interface is declared, it should not have a declare keyword. So declare interface JsonRefsOptions, it should just be interface JsonRefsOptions. _(Not sure if it should be export interface JsonRefsOptions, I'm new to TypeScript.

[wehrstedt]

Okay, I will have a look tomorrow

[wehrstedt]

I could easily reproduce this with the following jsdoc

/**
 * @module myModule
 */

/**
 * @interface myInterfaceInsideAModule
 * @memberof module:myModule
 */

which generates the following output

declare module 'myModule' {
    declare interface myInterfaceInsideAModule {
    }

}

The output should look like

declare module 'myModule' {
    interface myInterfaceInsideAModule {
    }

}

(the keyword "declare" is omitted for the interface)

[wehrstedt]

Good news: It can be fixed by just upgrading dts-dom

[wehrstedt]

@whitlockjc published v1.0.4. Can you verify it, please?

[whitlockjc]

v1.0.4 fixes my issues.