Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have tests. #40

Open
claucece opened this issue Aug 13, 2018 · 1 comment
Open

Have tests. #40

claucece opened this issue Aug 13, 2018 · 1 comment
Labels
architecture importance low An issue that is not very important. If we can have it, great - if not, it's OK too

Comments

@claucece
Copy link
Member

The test suite was introduced in fedd7a9 . We should have actual tests now.
@claucece claucece added importance low An issue that is not very important. If we can have it, great - if not, it's OK too architecture labels Aug 13, 2018
@olabini
Copy link
Contributor

olabini commented Mar 10, 2019

This would in theory be good, but right now I don't know how to test basically anything, since it all touches Pidgin stuff. I would say the first step would be to separate out the stuff that depends on glib/GTK/Pidgin libraries and separate out the rest, and test that. But that's a major refactoring, and I'm not sure how valuable it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture importance low An issue that is not very important. If we can have it, great - if not, it's OK too
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olabini @claucece