Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango warning entity escape ampersand #74

Closed
goatscrub opened this issue Jan 24, 2018 · 1 comment
Closed

pango warning entity escape ampersand #74

goatscrub opened this issue Jan 24, 2018 · 1 comment

Comments

@goatscrub
Copy link

Hi,

First of all, thank for your great work, I use gaupol frequently.

I discover an issue with pango markup when a subtitle contain a specific entity like the ampersand in it.
If a subtitle contains a non-escaped ampersand ("Youth & Government" for example), the gaupol video player drops subtitle content and display previous subtitle content in place.
The written file is not affected by this issue, as well as the external video player, this only occurs with the "internal" video player.

I test it with github version 1.3.1, console message is:

(gaupol:6698): Pango-WARNING **: pango_layout_set_markup_with_accel: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &

Similar case also exist with "<" char when it is alone, video player drops subtitle content and display previous subtitle, console message is different:

(gaupol:7930): Pango-WARNING **: pango_layout_set_markup_with_accel: Error on line 1 char 12: '<' is not a valid name

Sorry for my approximative english, I hope you understand the main idea, thanks.

@otsaloma
Copy link
Owner

Thanks, I understand. The subtitle text just likely needs a GLib.markup_escape_text call, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants