-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the compression format of input files through MIME types #5
Comments
Our usage is now totally guided by the extensions, we cannot fully rely on MIME types, but maybe add some checks before extracting some file. Like, if we are extracting a .tar.gz file, but it looks like something else, ask via dialog.rs/Confirmation if the user wants to proceed. But idk, this isn't an impactful change. |
I encountered a |
@mulimoen what if we support |
@marcospb19 That would work just as well for me! |
Closing after some internal discussions, we think it's better to check the MIME file types just to give the users previous advice when trying to decompress something that does not match up. |
ouch
currently determines the compression format of its input files through their extensions, which isn't idealThe text was updated successfully, but these errors were encountered: